Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #18

Merged
merged 15 commits into from
Apr 25, 2024
Merged

Update #18

merged 15 commits into from
Apr 25, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Apr 24, 2024

Fix the various build errors

@jburel jburel requested a review from will-moore April 24, 2024 13:21
@will-moore
Copy link
Member

Seems to be failing with:

+ OMERO_DIST=/opt/omero/server/OMERO.server
+ omero /omero-mkngff -h

Should be omero mkngff -h I think.

@jburel
Copy link
Member Author

jburel commented Apr 25, 2024

@will-moore @joshmoore I have removed the test in commit b0d11c1
this is coming from
https://github.com/German-BioImaging/omero-rdf/blob/main/test/integration/clitest/test_rdf.py
and it does not seem to make sense to have it in this repo

@will-moore
Copy link
Member

Failing on tests with:

    def test_mkngff(self, capfd):  # type: ignore
        name = self.uuid()
        object_type = "Project"
        oid = self.create_object(object_type, name=f"{name}")
        obj_arg = f"{object_type}:{oid}"
        self.args += [obj_arg]
>       out = self.rdf(capfd)
E       AttributeError: 'TestMkngff' object has no attribute 'rdf'

I don't know if these have ever passed? Look like they come from the cookiecutter at https://github.com/ome/cookiecutter-omero-cli-plugin/blob/9b08be31192faf9c8f128efe0f7155bc57b2556b/omero-%7B%7Bcookiecutter.cli_command%7D%7D/test/integration/clitest/test_%7B%7Bcookiecutter.cli_command%7D%7D.py#L41

@will-moore
Copy link
Member

Seems it needs at least 1 test to pass to be green.
Last run has:

============================== 1 warning in 0.31s ==============================
...
Error: Process completed with exit code 5.

Whereas the previous (green) has

========================= 1 passed, 1 warning in 0.56s =========================

@jburel jburel force-pushed the update branch 2 times, most recently from cfe1322 to 0788b60 Compare April 25, 2024 11:42
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - build is green. Thanks 👍

@jburel jburel merged commit c1f00b6 into IDR:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants