Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idr0012: Add roi import plugin #290

Closed
wants to merge 2 commits into from

Conversation

dominikl
Copy link
Member

CLI plugin to import the ROIs from the hdf5 file created by #289 .
Doesn't work yet, because there are 4 fields / well in the data, but only 2 fields / well in OMERO!
See my comment on https://trello.com/c/hjEUogsi/23-rois-idr0012-fuchs

@joshmoore
Copy link
Member

Finally got a chance to compare this and gh-287. We may need to discuss the naming collision here: there won't be a way to activate both of the plugins at the same time. Perhaps that's ok, since you'll only ever be running one at a time, but there would be no way to have them, e.g., all on the PYTHONPATH at the same time. This makes me think of a RoiReader and whether or not we should detect these "formats" at runtime.

@dominikl
Copy link
Member Author

dominikl commented Jan 22, 2018

That's true. I.e. have only one roiimport command (still looking for a better name btw) and specify format via an extra argument --format=idr0012, --format=idr0016, etc. ?

@joshmoore
Copy link
Member

Something like that, yes. It might be that as with readers.txt from Bio-Formats, we can specify the (Python) class name for --format in addition to some well-known formats (cellprofiler, etc)

@dominikl
Copy link
Member Author

Replaced by #292

@dominikl dominikl closed this Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants