Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spearhead 1944 (SPE) compatibility, Add SPEX compat #1335

Merged
merged 11 commits into from
Dec 12, 2024

Conversation

Drofseh
Copy link
Contributor

@Drofseh Drofseh commented Aug 6, 2024

When merged this pull request will:
Improve SPE compat

  • Add support for new Mortain terrain
  • Add PRC-77 to Milice radio backpack
  • Add custom radio configs to new armoured cars, tanks, tank destroyers, etc.
  • Fix some small issues with configs and stringtable

Add SPEX compat

  • Add support for Utah Beach and Carentan terrains

Drofseh added 4 commits August 1, 2024 12:21
- Zeroize inherited values for SPE_ArmoredCar_base
- Add PRC77 in racks to M8 and M20 armoured cars
@Drofseh Drofseh marked this pull request as ready for review August 24, 2024 23:52
@Drofseh Drofseh requested a review from PabstMirror September 4, 2024 06:42
@PabstMirror PabstMirror added this to the 2.13.0 milestone Sep 4, 2024
Copy link
Collaborator

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configs look fine

I'm not thrilled about adding new vehicles in a compat,
but I think I understand why it's being done

@Drofseh
Copy link
Contributor Author

Drofseh commented Sep 4, 2024

configs look fine

I'm not thrilled about adding new vehicles in a compat, but I think I understand why it's being done

The new vehicles should be in their 1.1.1 update, they didn't have time for them in 1.1

@jonpas
Copy link
Member

jonpas commented Sep 23, 2024

@Drofseh Needs conflict resolution, then good to merge.

@Drofseh
Copy link
Contributor Author

Drofseh commented Sep 24, 2024

@jonpas deconflicted

@Drofseh
Copy link
Contributor Author

Drofseh commented Oct 14, 2024

@jonpas or @PabstMirror can this be merged?
It's been a few weeks now since SPE updated and the new terrain isn't supported until this PR is released.

@Drofseh Drofseh changed the title Update Spearhead 1944 (SPE) compatibility for v1.1 release Update Spearhead 1944 (SPE) compatibility, add SPEX compat Nov 12, 2024
@jonpas jonpas changed the title Update Spearhead 1944 (SPE) compatibility, add SPEX compat Update Spearhead 1944 (SPE) compatibility, Add SPEX compat Dec 12, 2024
@jonpas jonpas merged commit cb9c208 into IDI-Systems:master Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants