Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Racks - Fix vehicle racks unable to use certain intercoms #1255

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

Quantx
Copy link
Contributor

@Quantx Quantx commented Jul 2, 2023

This PR fixes a bug where vehicle racks are only able to use the first configured intercom.

This is bug occurs because acre_sys_intercom_intercomNames contains a list of intercoms in the following format:

[["intercom_1","Crew Intercom","Crew"],["intercom_2","Pax Intercom","Pax"]]

However, the following code only checks the first entry in the above list:

private _configuredIntercoms = _vehicle getVariable [QEGVAR(sys_intercom,intercomNames), []];
if (_int in (_configuredIntercoms select 0)) then {

@jonpas jonpas added the bug fix label Jul 2, 2023
@jonpas jonpas added this to the 2.12.0 milestone Jul 2, 2023
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also fix the return value on L11 to * Wired Intercoms <ARRAY>.

addons/sys_rack/fnc_configWiredIntercoms.sqf Outdated Show resolved Hide resolved
addons/sys_rack/fnc_configWiredIntercoms.sqf Outdated Show resolved Hide resolved
@jonpas jonpas changed the title Racks - Fixed issue preventing vehicle racks from using certain intercoms Racks - Fix vehicle racks unable to use certain intercoms Jul 19, 2023
@Quantx Quantx requested a review from jonpas July 23, 2023 22:26
@jonpas jonpas merged commit 35c634b into IDI-Systems:master Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants