fix: seo service config #2517
Merged
fix: seo service config #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmcquade
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Fix issue where seo service fails to initialise if deployment does not have any app header config set
Dev Notes
The reason for the issue is that the seo-service was importing app config via the deployment config (which only includes config overrides), instead of app config service (which includes full merged config). So when accessing nested properties it would throw an error if no APP_HEADER_DEFAULTS had been overwritten.
Most deployments typically have app header overrides so would mostly go unnoticed, it was only when running the local deployment that the error was noticed. Searching the codebase this is the only service that I could see that tried to access app config in this way.
Git Issues
Closes #
Screenshots/Videos
Source code search for other services accessing app_config - only case is a comment in task-card component and the app-config service itself which handles merging full config values
