Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: full screen template screen orientation tracking #2514

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Nov 8, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Alt pr to #2511, to support screen orientation when triggered from fullscreen popup

Review Notes

Testing on feature_screen_orientation should allow for any template defined with parameter_list orientation: landscape to be forced into landscape mode both when navigated to ordinarily or when called as a fullscreen popup (video demo below).

Git Issues

Closes #2511

Screenshots/Videos

untitled.webm

Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice implementation. In general it feels good that we've now got ways of tracking the top-level template and any standalone template, could be useful in relation to other issues we've had in relation to navigation.

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested on plh_kids_tz deployment

WhatsApp.Video.2024-11-08.at.15.21.01_2c2dc212.mp4

@esmeetewinkel esmeetewinkel merged commit 9814642 into master Nov 8, 2024
6 checks passed
@esmeetewinkel esmeetewinkel deleted the feat/popup-screen-orientation-alt branch November 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants