Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: angular 18 update #2428

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

spike: angular 18 update #2428

wants to merge 5 commits into from

Conversation

chrismclarke
Copy link
Member

PR Checklist

  • PR title descriptive (can be used in release notes)

TODO

To simplify update best to independently create PRs to:

  • Update ionic/angular to latest version
  • Refactor lottie to standalone feature with tests and provider syntax
  • Update ngx-extended-pdf-viewer

Follow-up PRs could also include

  • Test compatibility builder
    (tested application builder and had issue with export * from statements, see various open issues so assume not ready yet)

Description

What this PR does

Review Notes

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@chrismclarke
Copy link
Member Author

@jfmcquade
I've created this branch to test upgrading to angular 18. There seems to be enough side-effects and refactoring required that I'm going to leave as draft for now and try to address specific issues in standalone PRs first (e.g. updating ionic and other angular-related dependencies to compatible versions)

@chrismclarke
Copy link
Member Author

@jfmcquade
Just so this doesn't totally fall of my radar - is upgrading ionic/angular to v8 still on your TODO list? I appreciate you've got a lot on so no issue if it's quite far down on the list.

From what I can see v8 is backwards compatible to angular 16 (so wouldn't require this PR), but I don't think ionic-angular v7 is compatible with angular 18.

So likely the best order of actions would be to upgrade ionic first and then angular next if we don't want to do them both at the same time. I don't think there's any major urgency to get angular updated, just aware that I had forgotten about this spike PR so deciding how best to deal with it.

@jfmcquade
Copy link
Collaborator

Thanks for flagging @chrismclarke, upgrading ionic had indeed fallen off my radar. I've made an issue here, noting that it would unblock this PR, and will prioritise when I can

@chrismclarke
Copy link
Member Author

Thanks for flagging @chrismclarke, upgrading ionic had indeed fallen off my radar. I've made an issue here, noting that it would unblock this PR, and will prioritise when I can

Thanks, yeah no major issue as I don't think this is blocking on anything else, just might be useful to deal with any component knock-ons whilst prepping a few upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scripts Work on backend scripts and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants