-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spike: angular 18 update #2428
base: master
Are you sure you want to change the base?
spike: angular 18 update #2428
Conversation
@jfmcquade |
@jfmcquade From what I can see v8 is backwards compatible to angular 16 (so wouldn't require this PR), but I don't think ionic-angular So likely the best order of actions would be to upgrade ionic first and then angular next if we don't want to do them both at the same time. I don't think there's any major urgency to get angular updated, just aware that I had forgotten about this spike PR so deciding how best to deal with it. |
Thanks for flagging @chrismclarke, upgrading ionic had indeed fallen off my radar. I've made an issue here, noting that it would unblock this PR, and will prioritise when I can |
Thanks, yeah no major issue as I don't think this is blocking on anything else, just might be useful to deal with any component knock-ons whilst prepping a few upcoming releases. |
PR Checklist
TODO
To simplify update best to independently create PRs to:
Follow-up PRs could also include
(tested application builder and had issue with
export * from
statements, see various open issues so assume not ready yet)Description
What this PR does
Review Notes
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes