Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlgConvertTocreating a working dialog #956

Merged
merged 3 commits into from
Feb 26, 2016
Merged

dlgConvertTocreating a working dialog #956

merged 3 commits into from
Feb 26, 2016

Conversation

nyagishira
Copy link
Contributor

No description provided.


Private Sub ucrSelectorDataFrameolumns_DataFrameChanged() Handles ucrSelectorDataFrameColumns.DataFrameChanged
ucrBase.clsRsyntax.AddParameter("data_name", Chr(34) & ucrSelectorDataFrameColumns.ucrAvailableDataFrames.cboAvailableDataFrames.SelectedItem & Chr(34))
TestOKEnabled()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the TestOKEnabled() here because changing the dataframe doesn't affect the OK button so you can remove this line.

@dannyparsons
Copy link
Contributor

Hi Mary, this is looking really great! There's just a couple of small changes to make and then it's good. Well done.

@dannyparsons
Copy link
Contributor

Thanks Mary.
When you make corrections in future to pull requests can you send a quick comment on here to say you've done it? Just because GitHub is a bit annoying in that I don't get an email notification when anyone updates a pull request. Thanks.

dannyparsons added a commit that referenced this pull request Feb 26, 2016
dlgConvertTo creating a working dialog
@dannyparsons dannyparsons merged commit 5c1d607 into IDEMSInternational:master Feb 26, 2016
dannyparsons added a commit that referenced this pull request Oct 10, 2018
MeSophie pushed a commit to MeSophie/R-Instat that referenced this pull request Sep 20, 2024
…inIssue9117

New start end rain issue9117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants