Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes paste from clipboard bug #9237

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

Patowhiz
Copy link
Contributor

@Patowhiz Patowhiz commented Nov 6, 2024

Fixes #9207
@N-thony @rdstern @jkmusyoka this is ready for your review.

I've also provided detailed information on how this bug originated in issue #9207. Would be good to read the comment because it may relate to other future potential problems.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Patowhiz and @N-thony I think it is now working fine, so I am approving. But I note as follows:
a) pasting within a dataframe gave an error, saying clipr was not installed. I assume that's just my machine, and it will be installed in the proper version? Anyway I installed clipr and it now seems to work fine.
b) The paste new now works - at least starting from Excel. I have sent a message and data in word, as it didn't work for me directly from word (It did paste into Excel and then from Excel to R-Instat.

@N-thony
Copy link
Collaborator

N-thony commented Nov 7, 2024

@rdstern I'm going to merge this.

@N-thony N-thony merged commit 11f4f92 into IDEMSInternational:master Nov 7, 2024
2 checks passed
@Patowhiz
Copy link
Contributor Author

Patowhiz commented Nov 7, 2024

@rdstern can you confirm if it pastes from word? I sent a response that you may need to download the file and copy from MS word not from the browser preview. It worked on my end.

@rdstern
Copy link
Collaborator

rdstern commented Nov 7, 2024

@Patowhiz I did download the file and then opened word on the desktop. It still didn't paste - though it seems fine from Excel. I looked for a reason from stackoverflow, but couldn't resolve that.

@Patowhiz
Copy link
Contributor Author

@rdstern I tested using the ZMD participants file that you sent. The limitation is in clipr package due to the way the contents are copied from word to the clipboard. When you open the word document, notice the spacing in the first participant. that's what is making clipr to fail. Pasting to excel or even notepad first then to R-Instat works because that first line after header is corrected.

Copying from Word to R-Instat
word

Copying from Excel or Notepad to R-Instat
excel

Copying directly from clipboard using clipr - This confirms it's a clipr issue.
pasting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste no longer works in the test version
4 participants