-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes in the append to variable metadata function #9217
Bug fixes in the append to variable metadata function #9217
Conversation
@N-thony in preparation I wanted to check that I do get this problem in the merged version now. (Because I didn't before updating to R 4.4.1.) I do get it, so I can't now import efc, until your bug fix. I notice, at the same time, there are still packages missing from the merged version. In particular I had to add sjlabelled earlier today. And sjmisc, sjplot, etc are not yet there. In the set of packages with datasets the last one in the alphabetical list is tidyr. In version 0.8 there are 20 packages after that. So we are missing a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdstern I'm still investigating but I found in the code, we were still targeting packages from version 4.1.0, this need to change to 4.4.1 so that we can generate the appropriates packages versions to install for R 4.4.1 |
@rdstern this is quite advanced R changes on functions used by different data book R functions. Considering @lilyclements has been looking at documenting the data book and summary R functions, I recommend her to review and approve. I'm happy to merge but I can't reliably check what other areas may be affected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #9208
Fixes #9209
Fixes #9211
@rdstern this fixes the bug when trying to convert a column or importing the efc data and also the one in
calculate_summary
. Have a look.