Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding four new keys to functions keyboard #9178

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

Fidel365
Copy link
Contributor

@Fidel365 Fidel365 commented Oct 8, 2024

Fixes partially #7659
@rdstern this is ready for review

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 that looks good.
a) Trivial change in the tooltip for frac_den is to delete the word for in For example for .
b) Now you need to add those functions from the issue into the code. Note I have corrected frac_den in the issue there. I replaced the word denominator, by den in the function. Maybe check with @N-thony or @Vitalis95 if you don't know how to do this.

@rdstern
Copy link
Collaborator

rdstern commented Oct 12, 2024

@Fidel365 you have gone quiet again? It would be good to finish this pull request.

@Fidel365
Copy link
Contributor Author

@rdstern I have made the changes requetsed and this is ready for a rereview, I would also like to appreciate @Vitalis95 for getting a hand in initiating this.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 and @Vitalis95 this looks fine now. Great!
@N-thony over to you.

@N-thony N-thony merged commit eb578e0 into IDEMSInternational:master Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants