Added Distances dialog to Climatic > Check data #9166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdstern , have a look at it |
rdstern
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
@Vitalis95 great, I am approving.
One small question below. but @N-thony can you check and merge if ok?
Here are some results for Malawi:
They are given with 4 decimal places, so that is the distance to the nearest 10cms! We don't really need that accuracy.
Is it easy to round to the nearest 10 metres, so 2 decimals?
N-thony
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
@Vitalis95 this looks good, and I guess you will consider solving @rdstern's question in a new PR?
|
@N-thony , let me do it here then you can merge |
It is better you do it in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partly #9136
@rdstern @N-thony , implemented the first part -
Values