Formatting Script #9153
Formatting Script #9153
Conversation
|
@derekagorhom I must be missing something? I loaded a script and pressed right-click and here is what I got:
I don't see any difference, or formatting options? What should I have done? Should I have installed a package? |
|
@rdstern The reformat option is on the Edit Menu now |
|
@rdstern you have now Reformat Code in the right click menu. Of course, you need to select the text you want to reformat. |
There was a problem hiding this comment.
@N-thony that's great.
I like the right-click, and I like it being called Reformat Code.
Do we still want the Format Code in the edit menu? If so, should there be a line above and should it be Reformat Code for consistency with the right-click option?
I am approving while you consider this. @Patowhiz could you check, react and merge?
|
@rdstern I removed format code menu |
instat/ucrScript.vb
Outdated
| @@ -1025,4 +1068,7 @@ Public Class ucrScript | |||
| sender.Dispose() | |||
| End Sub | |||
|
|
|||
| Private Sub mnuReformatCode_Click(sender As Object, e As EventArgs) Handles mnuReformatCode.Click | |||
| FormatRCode() | |||
There was a problem hiding this comment.
@N-thony if FormatRCode() is used once, then just put it's functionality inside the mnuReformatCode click event.
Same with EscapeDoubleQuotes() function. It's just one line and if used in one place only, just call the single line where it is used.
This will simplify the functionality added consequently making it easier to maintain.
instat/ucrScript.vb
Outdated
| Dim formattedText As String = String.Join(Environment.NewLine, formattedCode) | ||
|
|
||
| ' Check if there is any selected text | ||
| If clsScriptActive.SelectionStart <> clsScriptActive.SelectionEnd Then |
There was a problem hiding this comment.
@N-thony I don't quite understand the need for this check. Line 1023 Dim scriptText As String = clsScriptActive.SelectedText.Replace("""", "\""") alreadu assumes there is selected text. That's why it is formatting the it. Why do you need to check for selection again? I though if there is no selection, formatting shouldn't happen.
If there is a case when you are allowed to format nothing, shouldn't the test for selection be done before line 1023 is executed?
There was a problem hiding this comment.
It doesn't make sense to reformat nothing, I have made a change for an early sub exit when nothing is selected.
I hope this makes more sense, have a look
|
@N-thony please can you check for me. I am trying to check, while on a train, so may hace it weong. But when I select a part of the code and then right-click it seems to unselect it. So I haven't been able to reformat. |
@rdstern it is fine on my end |
fixes partly #8847
@rdstern @derekagorhom have a look of the formatting of the script.