Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements to the front menu #9069

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

Fidel365
Copy link
Contributor

Fixes issue #9058
@rdstern this is ready for review, but I will also invite @rachelkg to check if this in now ok.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 thanks for adding the Online bit.
Now I'm not good at this spacing stuff and @N-thony . But I would like this initial screen to look as professional as possible.
There seems to me to be a bigger space before the Advanced section, compared to the others.
And is the spacing between the 3 items in Advanced, the same as those between the Help items? And the Paste data - is that exactly the same space below the items as the other?
@Fidel365 you were really good at making the calculator keyboards much neater. Can you have a similar go at the spacing here?
This is important, because it is going to be visible at the start every time anyone uses R-Instat. And I'm keen that we give a really good initial impression.

@Fidel365
Copy link
Contributor Author

@rdstern have a look at the recent channges.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 I think that looks much better now. Many thanks.
A trivial point. The Restore Data from Backup... needs the 3 dots. And I take the opportunity to delete the or Log, so it is a simpler message.
@rachelkg could you also cast your critical eye over this, before it is merged - though changes could also happen later.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 perfect - I like it. @N-thony over to you to check and merge. Maybe @rachelkg will comment before?, if not, then don't wait. I am keen to have this new screen

@N-thony N-thony merged commit 4264231 into IDEMSInternational:master Jul 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants