Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Export Climatic following functionality amendments in the R Code #9009

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

lilyclements
Copy link
Contributor

Fixes #9003, adding definitions_id to export dialog following changes in the export_r_instat_to_bucket function in the epicsawrap package.

@N-thony I'm not sure the process on checking/reviewing these days. I did this myself since it was a simple enough change that I felt it was easier this way. Can you review/suggest someone to review? Thanks!

@rdstern
Copy link
Collaborator

rdstern commented Jun 15, 2024

@jkmusyoka please can you approve so @N-thony can merge. Thanks

Copy link
Contributor

@jkmusyoka jkmusyoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-thony I am approving this. Please merge this so that @Vitalis95 can update the changes then I can test PR 9028

@N-thony N-thony merged commit fbfa223 into IDEMSInternational:master Jun 21, 2024
2 checks passed
@lilyclements lilyclements deleted the dlgEPICSA_9003 branch October 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add definitions_id to Export to Google Buckets
4 participants