Improved the R code in parallel coordinates plot dialog #8987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
reviewed
May 23, 2024
There was a problem hiding this comment.
@Vitalis95 that's great - and it seems to work. Just one small point.
# Dialog: Parallel Coordinate Plot
iris <- data_book$get_data_frame(data_name="iris")
column_numbers <- match(c("Sepal.Length","Sepal.Width","Petal.Length","Petal.Width"), names(iris))
last_graph <- GGally::ggparcoord(data=iris, columns=c("Sepal.Length","Sepal.Width","Petal.Length","Petal.Width"),
groupColumn="Species", missing="exclude", order=column_numbers, centerObsID=1) + theme_grey()
data_book$add_object(data_name="iris", object_name="last_graph", object_type_label="graph", object_format="image", object=check_graph(graph_object=last_graph))
data_book$get_object_data(data_name="iris", object_name="last_graph", as_file=TRUE)
rm(list=c("last_graph", "iris", "column_numbers"))
Why not make columns=column_numbers in the code? There will sometimes be a lot of columns and there is then no need to repeat the names twice?
Then I would like to merge this quickly, so very happy for the other problem to be in a separate pull request.
|
@rdstern , have a look at it |
rdstern
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
@Vitalis95 that's great. Well done both of us! @N-thony could you check and (I hope) merge.
N-thony
requested changes
May 24, 2024
instat/dlgParallelCoordinatePlot.vb
Outdated
Comment on lines
444
to
446
| Private Sub ucrReceiverXVariables_ControlValueChanged(ucrChangedControl As ucrCore) Handles ucrReceiverXVariables.ControlValueChanged | ||
| clsMatchFunction.AddParameter("var", ucrReceiverXVariables.GetVariableNames, bIncludeArgumentName:=False, iPosition:=0) | ||
| End Sub |
There was a problem hiding this comment.
Same here
ucrReceiverXVariables.AddAdditionalCodeParameterPair(clsMatchFunction, New RParameter("var", 1, bNewIncludeArgumentName:=False), iAdditionalPairNo:=2)
N-thony
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #8985
@rdstern @N-thony , this fixes parallel coordinates plot dialog. I will do the remaining part in a separate PR