Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding help id's for snippets-2, and general improvements to calculator #8981

Closed
wants to merge 0 commits into from

Conversation

Fidel365
Copy link
Contributor

Fixes partially #8889
We now continue with the second set, I am afraid it's partially because I don't want to changes on the calculator while the functions keyboard is not yet merged to avoid conflicts to that branch. So, I will work on the calculator part once I am done with functions keyboard, else, this is ready for review.

@rdstern
Copy link
Collaborator

rdstern commented Jun 7, 2024

@Fidel365 please could you check item f) One Variable Summarise in the changes you made. I have yet to check all the changes, but most seem to be working.

However, Describe > One Variable > Summarise still goes to the Prepare > Check Data > Summarise place. Could you please check that you included the help context as 410 for the Describe > One Variable > Summarise. It happens to be the one that Beryl needs to use in her latest video.

Thanks

Roger

@Fidel365
Copy link
Contributor Author

Fidel365 commented Jun 8, 2024

@rdstern, this PR is ready for review and it covers the following items

  1. There was a problem with help of add key dialogue which was going in a different place, now it works, both in prepare and climatic
  2. The issue with f). one variable summarise in the describe menu is now resolved.
  3. Calculator__
    I have merged the transform keyboard changes here and hence this should be treated as the final point.
    Note; I would love the PR for the transform keyboard to merged first, it's Mainly improving the transform keyboard #9002 before this one so as to avoid conflicts.
    • The circular keyboard is now default when you go to structured>circular; i thought this should be the case by default?
    • The help context numbers to the 2 menus is now added and correctly working
    • I have been adjusting keys that have () to ( ) and putting the cursor right at the start so that the user can know that they need to add something in that space btwn them, Most of the keys that have the same criteria should now look in the similar way as I have been correcting them also.
      Fidel.

@Fidel365 Fidel365 changed the title Adding help id's for snippets-2 Adding help id's for snippets-2, and general improvements to calculator Jun 8, 2024
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 this is all looking good - including your clear explanations.
I omitted to give you the Structured > Circular > Define ID, wheich is 175.
I note you wanted #9002 merged first. This is approved and I am checking with @N-thony

@Fidel365
Copy link
Contributor Author

@rdstern , I am working on the changes on a new branch, this has conflicts and so we had to move to another branch. I will update once it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants