Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding help id's for snippets in R-instat #8923

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Adding help id's for snippets in R-instat #8923

merged 7 commits into from
Apr 11, 2024

Conversation

Fidel365
Copy link
Contributor

@Fidel365 Fidel365 commented Apr 8, 2024

Fixes partially issue #8889.
Partially because part (a) is not yet fixed.
@rdstern this PR is ready for review

rdstern
rdstern approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 great.
I have kept your partially, though the point a) you mention - good spot - is now ok. But there is a second set of help IDs that are to come later, but are only partially there now. So no more work on this issue yet.
@N-thony over to you.

@N-thony N-thony merged commit 983e155 into IDEMSInternational:master Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-thony N-thony N-thony approved these changes

@rdstern rdstern rdstern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fidel365 @rdstern @N-thony