Improvements to the plot geom sub-dialog

[Vitalis95]

Fixes Partially #8760
@rdstern this fixes a) and b) on corrections for Label.X and Label.Y
@N-thony on the part of Label.X.npc and Label.Y.npc the radio button for linking them is not defined in ucrGeoms. I have sent you a message about this on skype

[rdstern]

@Vitalis95 that seems to work. For the remaining bit, would it make the change simple to do if you simply changed the control for the label.x.npc options. So, just a single receiver that can take a number - any number including negative and entrered, rather than an up-down. m Maybe you could check in the documentation, because I suggest that's what is usually needed?

[Vitalis95]

@rdstern , label.x.npc can be either numeric or character. It is now set as character. If it is numeric, value should be between 0 and 1. Can I change it to up-down with min is 0 and max is 1?

[rdstern]

@Vitalis95 if you are right, that they are 0 to 1 then an up-down would be fine. But I thought they were tied to the actual x and y scales, so could be anything? I hope I am wrong, because that might get tricky if one axis is a date! So could you check in the documentation first?

[Vitalis95]

@rdstern , from the documentation ,label.x.npc, label.y.npc specify the positioning of the correlation coefficient labels on the plot. For example, the label.x.npc is set to "left", which means the correlation coefficient labels will be positioned towards the left side of the plot, and label.y.npc is set to "top", which means the labels will be positioned towards the top of the plot.
They are not tied to the actual x and y scales

[Vitalis95]

@rdstern I think it is preferable for label.x.npc andlabel.y.npcto stay as characters because it specify the positions top, middle, and center..., rather than being numeric

[rdstern]

@Vitalis95 you were right on the npc values, if they are numeric, being in the 0 to 1 scale. And - ok let's leave them as character for now.
For the label.x and label.y you have made it an up-down with a step of 1. That would give problems if the y-scale was from 0 to 1 etc. So could it be just where you type a number - and without the up-down control.

[Vitalis95]

@Vitalis95 you were right on the npc values, if they are numeric, being in the 0 to 1 scale. And - ok let's leave them as character for now. For the label.x and label.y you have made it an up-down with a step of 1. That would give problems if the y-scale was from 0 to 1 etc. So could it be just where you type a number - and without the up-down control.

@N-thony , in the ucrGeom, when I set as an input where you type a number, the number comes as string when you run, how can I remove the double quotes there? When you check in ucrGeom ,the up-down is used for numeric

[N-thony]

@Vitalis95 you were right on the npc values, if they are numeric, being in the 0 to 1 scale. And - ok let's leave them as character for now. For the label.x and label.y you have made it an up-down with a step of 1. That would give problems if the y-scale was from 0 to 1 etc. So could it be just where you type a number - and without the up-down control.

@N-thony , in the ucrGeom, when I set as an input where you type a number, the number comes as string when you run, how can I remove the double quotes there? When you check in ucrGeom ,the up-down is used for numeric

@Vitalis95 try this

[Vitalis95]

@rdstern , have a look at now

[N-thony]

@Vitalis95 you were right on the npc values, if they are numeric, being in the 0 to 1 scale. And - ok let's leave them as character for now. For the label.x and label.y you have made it an up-down with a step of 1. That would give problems if the y-scale was from 0 to 1 etc. So could it be just where you type a number - and without the up-down control.

@N-thony , in the ucrGeom, when I set as an input where you type a number, the number comes as string when you run, how can I remove the double quotes there? When you check in ucrGeom ,the up-down is used for numeric

@Vitalis95 try this

@Vitalis95 can you also correct the title of this PR?

[rdstern]

@Vitalis95 great, that's working now. @N-thony I am approving. (I note that if I type roger there instead of a number I get an error of course. But I am becoming quite happy with that error, because if I go to a script and run roger <- 35, then it is quite happy!)

[rdstern]

@N-thony is this ok to merge?