Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix in stand alone function file #8787

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Bug fix in stand alone function file #8787

merged 1 commit into from
Feb 2, 2024

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Feb 2, 2024

Fixes #8780
@rdstern have a look.

@N-thony N-thony mentioned this pull request Feb 2, 2024
Closed
rdstern
rdstern approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-thony phew - you seem to have fixed it. I am relieved. It would be good if you could add a note on what you had to do, in case we get a similar problem in the future.
How can we get it merged now?

@N-thony
Copy link
Collaborator Author

N-thony commented Feb 2, 2024 •
edited
Loading

@N-thony phew - you seem to have fixed it. I am relieved. It would be good if you could add a note on what you had to do, in case we get a similar problem in the future. How can we get it merged now?

@rdstern there is a note in the issue. We need a second approval to get it merged
@derekagorhom can you approve this then I will merge it quickly?

@dannyparsons dannyparsons merged commit e76ec70 into IDEMSInternational:master Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vitalis95 Vitalis95 Vitalis95 approved these changes

@derekagorhom derekagorhom derekagorhom approved these changes

@rdstern rdstern rdstern approved these changes

@dannyparsons dannyparsons dannyparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import data not working after getting the last update
5 participants
@N-thony @dannyparsons @rdstern @derekagorhom @Vitalis95