Fixes bug where the script tab prompt does not come with a name #8761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekagorhom
changed the title
rdstern
reviewed
Jan 24, 2024
There was a problem hiding this comment.
@derekagorhom I tried with a simple script and gave it a name and I still don't get the prompt. I assume if I didn't give a name then the Save dialog would prompt with Untitled1 as the name.
I wonder if you have fixed something different. Perhaps you could give a screen-shot of an example that you tested?
|
@rdstern i have made new changes to the pull request can you review this again. |
rdstern
previously approved these changes
Jan 26, 2024
N-thony
requested changes
Jan 26, 2024
instat/ucrScript.vb
Outdated
| @@ -214,6 +218,7 @@ Public Class ucrScript | |||
| Using dlgSave As New SaveFileDialog | |||
| dlgSave.Title = "Save " & If(bIsLog, "Log", "Script") & " To File" | |||
| dlgSave.Filter = "R Script File (*.R)|*.R|Text File (*.txt)|*.txt" | |||
| dlgSave.FileName = Path.GetFileName(SelectedTab) | |||
There was a problem hiding this comment.
dlgSave.FileName = Path.GetFileName(TabControl.SelectedTab.Text)
instat/ucrScript.vb
Outdated
Comment on lines
199
to
201
| Private Function SelectedTab() As String | ||
| Return TabControl.SelectedTab.Text | ||
| End Function |
There was a problem hiding this comment.
This has been removed
N-thony
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8722
This fixes the problem of when the script tab does not prompt the user with the name.
@rdstern , @N-thony this PR is ready for review.
Thanks