-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dlgPolynomials: adding r code to the dialog #872
dlgPolynomials: adding r code to the dialog #872
Conversation
Replicate working
Editing Front End
@@ -35,4 +49,25 @@ Public Class dlgPermuteRows | |||
|
|||
End If | |||
End Sub | |||
|
|||
Private Sub txtNumberOfPerColumns_Leave(sender As Object, e As EventArgs) Handles txtNumberOfPerColumns.Leave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is NumberOfPerColumn an integer? If so then you should replace the text box with a numeric up down.
You've called this pull request dlgPolynomials, but this is not included and there are 2 other dialogs in here. Did you mean to do that? |
Hey Danny, I will fix it to accommodate integer: Regards, On Fri, Feb 19, 2016 at 12:39 PM, Danny Parsons [email protected]
|
Hi Danny, I have checked in r and set.seed() is working with decimals. So, I have Thanks Regards, On Fri, Feb 19, 2016 at 12:59 PM, John Lunalo [email protected]
|
John, you didn't read my comment carefully: I didn't say it only works for integers, I said we use make sure it is an integer in the dialog. And the reason is from the R help.
So yes, it does work with decimal numbers, but it is meant to be an integer, and if you give a decimal, it interprets it as an integer. Therefore I think we should only allow integers to be entered. It's great that you went to R to see how the function works, but you also need to read the help carefully to understand the meaning of each parameter. |
Thanks for that Clarification Danny On 2/19/16, Danny Parsons [email protected] wrote:
Regards, |
…es in the vb code
hi Danny, I have made those changes. Thanks Regards, On Fri, Feb 19, 2016 at 2:09 PM, John Lunalo [email protected] wrote:
|
dlgPermuteRows: adding R code to the dialog
Replicate working