Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlgPolynomials: adding r code to the dialog #872

Merged
merged 6 commits into from
Feb 19, 2016
Merged

dlgPolynomials: adding r code to the dialog #872

merged 6 commits into from
Feb 19, 2016

Conversation

Lunalo
Copy link
Contributor

@Lunalo Lunalo commented Feb 19, 2016

Replicate working

@@ -35,4 +49,25 @@ Public Class dlgPermuteRows

End If
End Sub

Private Sub txtNumberOfPerColumns_Leave(sender As Object, e As EventArgs) Handles txtNumberOfPerColumns.Leave
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is NumberOfPerColumn an integer? If so then you should replace the text box with a numeric up down.

@dannyparsons
Copy link
Contributor

You've called this pull request dlgPolynomials, but this is not included and there are 2 other dialogs in here. Did you mean to do that?

@Lunalo
Copy link
Contributor Author

Lunalo commented Feb 19, 2016

Hey Danny,

I will fix it to accommodate integer:
The last one is dlgPermute. Sorry for that

Regards,
John Ong'ala Lunalo|| Kenyatta University Alumnus||
Volunteer, African Maths Initiative||
Email Address :[email protected]
Tel: +254701519572, +254786438572

On Fri, Feb 19, 2016 at 12:39 PM, Danny Parsons [email protected]
wrote:

You've called this pull request dlgPolynomials, but this is not included
and there are 2 other dialogs in here. Did you mean to do that?


Reply to this email directly or view it on GitHub
#872 (comment)
.

@Lunalo
Copy link
Contributor Author

Lunalo commented Feb 19, 2016

Hi Danny,

I have checked in r and set.seed() is working with decimals. So, I have
only replaced for "n" which seems to only work with integers

Thanks

Regards,
John Ong'ala Lunalo|| Kenyatta University Alumnus||
Volunteer, African Maths Initiative||
Email Address :[email protected]
Tel: +254701519572, +254786438572

On Fri, Feb 19, 2016 at 12:59 PM, John Lunalo [email protected]
wrote:

Hey Danny,

I will fix it to accommodate integer:
The last one is dlgPermute. Sorry for that

Regards,
John Ong'ala Lunalo|| Kenyatta University Alumnus||
Volunteer, African Maths Initiative||
Email Address :[email protected]
Tel: +254701519572, +254786438572

On Fri, Feb 19, 2016 at 12:39 PM, Danny Parsons [email protected]
wrote:

You've called this pull request dlgPolynomials, but this is not included
and there are 2 other dialogs in here. Did you mean to do that?


Reply to this email directly or view it on GitHub
#872 (comment)
.

@dannyparsons
Copy link
Contributor

John, you didn't read my comment carefully:
"It should be an integer (although a non integer will not give an error). To keep it simple I think we use a numeric up down here as well."

I didn't say it only works for integers, I said we use make sure it is an integer in the dialog. And the reason is from the R help.
See the R help for set.seed:

seed: a single value, interpreted as an integer

So yes, it does work with decimal numbers, but it is meant to be an integer, and if you give a decimal, it interprets it as an integer. Therefore I think we should only allow integers to be entered.

It's great that you went to R to see how the function works, but you also need to read the help carefully to understand the meaning of each parameter.

@Lunalo
Copy link
Contributor Author

Lunalo commented Feb 19, 2016

Thanks for that Clarification Danny

On 2/19/16, Danny Parsons [email protected] wrote:

John, you didn't read my comment carefully:
"It should be an integer (although a non integer will not give an
error
). To keep it simple I think we use a numeric up down here as well."

I didn't say it only works for integers, I said we use make sure it is an
integer in the dialog. And the reason is from the R help.
See the R help for set.seed:

seed: a single value, interpreted as an integer

So yes, it does work with decimal numbers, but it is meant to be an integer,
and if you give a decimal, it interprets it as an integer. Therefore I think
we should only allow integers to be entered.

It's great that you went to R to see how the function works, but you also
need to read the help carefully to understand the meaning of each
parameter.


Reply to this email directly or view it on GitHub:
#872 (comment)

Regards,
John Ong'ala Lunalo|| Kenyatta University Alumnus||
Volunteer, African Maths Initiative||
Email Address :[email protected]
Tel: +254701519572, +254786438572

@Lunalo
Copy link
Contributor Author

Lunalo commented Feb 19, 2016

hi Danny,

I have made those changes.

Thanks

Regards,
John Ong'ala Lunalo|| Kenyatta University Alumnus||
Volunteer, African Maths Initiative||
Email Address :[email protected]
Tel: +254701519572, +254786438572

On Fri, Feb 19, 2016 at 2:09 PM, John Lunalo [email protected] wrote:

Thanks for that Clarification Danny

On 2/19/16, Danny Parsons [email protected] wrote:

John, you didn't read my comment carefully:
"It should be an integer (although a non integer will not give an
error
). To keep it simple I think we use a numeric up down here as
well."

I didn't say it only works for integers, I said we use make sure it is an
integer in the dialog. And the reason is from the R help.
See the R help for set.seed:

seed: a single value, interpreted as an integer

So yes, it does work with decimal numbers, but it is meant to be an
integer,
and if you give a decimal, it interprets it as an integer. Therefore I
think
we should only allow integers to be entered.

It's great that you went to R to see how the function works, but you also
need to read the help carefully to understand the meaning of each
parameter.


Reply to this email directly or view it on GitHub:

#872 (comment)

Regards,
John Ong'ala Lunalo|| Kenyatta University Alumnus||
Volunteer, African Maths Initiative||
Email Address :[email protected]
Tel: +254701519572, +254786438572

dannyparsons added a commit that referenced this pull request Feb 19, 2016
dlgPermuteRows: adding R code to the dialog
@dannyparsons dannyparsons merged commit d9c68e1 into IDEMSInternational:master Feb 19, 2016
dannyparsons added a commit that referenced this pull request Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants