-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Climpact dialogue that exports station data in Climpact2 format #8708
Conversation
@derekagorhom. Attached is a text file with the R function. I am also attaching an example dataset for usage. Over to you! |
@N-thony from @jkmusyoka, His R function looks like a stand alone function. please can you help me with the implementation since i have not done some before. |
@N-thony , the discussion we had was i make the design and he looks at it and come up with the R function |
@derekagorhom my connection is not good now. But I think you need to check with @jkmusyoka about his R function that will reflect this Dialogue if you agreed about this design. |
@jkmusyoka I think the Rfunction should have |
@derekagorhom I have edited the earlier R function to now assume the data frame has year, month, day, etc columns. I hope this one works |
@jkmusyoka The Pull request is ready for review |
@derekagorhom Thanks but there are some build up errors. Kindly check from your end |
@jkmusyoka can you review this again, On the top menus you will see |
Me.Text = "R-Instat " + My.Application.Info.Version.Major.ToString + "." + | ||
My.Application.Info.Version.Minor.ToString + "." + | ||
My.Application.Info.Version.Build.ToString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the version number back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been added
instat/dlgExportForClimpact.vb
Outdated
Private Sub ucrReceiverElements_ControlContentsChanged(ucrChangedControl As ucrCore) Handles ucrReceiverRR.ControlContentsChanged, ucrReceiverTN.ControlValueChanged, ucrReceiverDay.ControlValueChanged, ucrReceiverYear.ControlValueChanged, ucrInputExportFile.ControlContentsChanged, ucrReceiverTX.ControlValueChanged, ucrReceiverMonth.ControlValueChanged | ||
TestOkEnabled() | ||
End Sub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this after line 158
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the change
Thanks @derekagorhom. @N-thony this is now approved and ready for merging |
@jkmusyoka you have approved but your approval is not giving access to merge this. I think it is something to check with Chris when he is back. @rdstern can you approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on James' behalf. @N-thony can you merge.
Fixes #8634
Added the Climpact dialogue that exports station data
go to
Climatic
>File
>Export to Climpact
This is not ready for preview
@jkmusyoka, this is the design preview.
this will not produce an output since we do not have the
R function
forClimpact
yet