Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Some issue on Describe>Graphs>Histogram and Boxplot Dialog #8670

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

MeSophie
Copy link
Contributor

Fixes #8659
@rdstern I Fixed the oddity issue on Histogram and Boxplot Dialogs . Please have a look.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie on the ridge plots for say climatic data, (like dodoma, the fill now seems to work fine, but colour still doesn't?
The boxplot options work well now.

@MeSophie
Copy link
Contributor Author

@rdstern please can you check again?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It still didn't like me just adding colour?

@MeSophie
Copy link
Contributor Author

It still didn't like me just adding colour?

@rdstern since you didn't fill the colour control in the aesthetics you will not have the colour on the graph. Because on the main dialog when we use Density/ridges button, the two receivers are for x and y parameters. If you want color without going to sub dialog then I cant add a receiver for colour.

@rdstern
Copy link
Collaborator

rdstern commented Nov 27, 2023

@MeSophie I was happy to go to the sub-dialog. Now - after your change (many thanks), I can add fill on the sub-dialog. Oh, now I can add colour! I'll approve.
@N-thony can you check the code and then merge if all is ok.

@N-thony N-thony merged commit cc66e6b into IDEMSInternational:master Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix oddity on to Describe > Graphs > Histogram and boxplot dialogs
3 participants