Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Small Bug in General Graph Dialog #8653

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

MeSophie
Copy link
Contributor

Fixes #8651
@rdstern I fixed the small bug on Facet options. Please have a look.

@rdstern
Copy link
Collaborator

rdstern commented Nov 17, 2023

@MeSophie it still seems to have the problem.
survey_with_summary.zip

I tried with these data that have multiple sheets. First went into the dialog, with the main survey data. Then Close, moved to a summary sheet and went back in to the dialog and reset and then facets. And it is still stuck on the original survey sheet.

image

@MeSophie
Copy link
Contributor Author

@rdstern please can you check again?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie great it seems to be fixed.
@N-thony I suggest it can be merged when you approve.

@MeSophie
Copy link
Contributor Author

@N-thony @Patowhiz Please can someone merge this? I have another work on General Graphics Dialog and I want to push it. Thank you.

@N-thony N-thony merged commit 9c5713c into IDEMSInternational:master Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another small bug in the general graphics dialog
4 participants