In Script window, implemented ?? operator and ensured tildas correctly parsed #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
@lloyddewit it is looking so good now. Everything I tried now seems to run, except - as you know - poor Florence Nightinggale - and in Crimea too!
@Patowhiz if you are ok with the code, this is another step forward!
Patowhiz
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rdstern
For details of these changes, please see:
I think this PR also fixes #8533. I think that the only remaining parts of this issue are covered by lloyddewit/RScript#19. Please check.
Apart from keywords and curly brackets, do you have any other R code that is not correctly parsed by the RScript library?
Thanks