Improvements to the Describe > Two variable Summarise Dialog

[Vitalis95]

Fixes #7262
Replace PR #7999
@rdstern have a look at the progress so far.
@N-thony @lilyclements
Thanks

[rdstern]

@Vitalis95 this is now looking very promising. I am ignoring the correlations and ANOVA options for now.
Here is the first option:

It all seems to work, but we need to add 2 options.
a) Margin - as in the other option i.e. Factor by Factor
b) A display option - though I a not sure of the existing one in the general Summary tables - it doesn't seem ideal. I am not sure quite what we need here, so let me explain

Here is the current layout:

a) The alternative would be to have Summaries in Rows. Perhaps that's just a checkbox? If checked it swaps the rows and columns, in the above display.
b) This is giving all the summaries for one variable and then the second variable. The alternative is to give the summaries together. So the 2 means, then etc. Maybe a checkbox saying Summaries Together, with the default checked.

Now to the factor by factor:

This is fine as long as I just do the default. But if I press for the Margin then it gives an error.

This gives:

Once I get this error, it also gives the same error when I untick the Margin - so then it won't do the default table it did before.

I also get an error when I start again than then ask for percentages.

[Vitalis95]

@rdstern , have a look at it

[rdstern]

@Vitalis95 that's great.
On the Factor by Factor the one item I suggest differently is not to display the summary name column:

That's the count_variable - repeated each row. I suggest we just have the table of results.

I am relieved we now seem to have something that seems to work with all the options for factor by factor.

[Patowhiz]

@Vitalis95 if you could resolve @rdstern above comments then I can proceed with my initial review. Thanks.

[rdstern]

@Vitalis95 I am now approving this in its current form.
There is a new pull request needed when @lilyclements helps, to be able to change the order of the summaries and variables in the dialog below.

When that is done, then also could simplufy the label given below to Summaries in Rows

This is a great one and long lasting, so delighted when it is merged. I hope @N-thony can check the code soon.

[N-thony]

Looks good, just some commented codes I think you need to remove them?

[Vitalis95]

@N-thony , over to you

[rdstern]

@N-thony this still looks ok to me