Added reorder control to histogram plot #8547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fidel365 I think you have tested by now, have you? If so then did you notice that the initial problem I had, still remains? This is the code for the historgam initially, with no factor. It should return to that if I add the factor and then take it away. 
Thanks. |
|
@rdstern , the recent changes now fixes the issue and this ready for rechecking |
rdstern
previously approved these changes
Sep 22, 2023
There was a problem hiding this comment.
@Vitalis95 and @Fidel365 this is great. What a happy outcome. @N-thony can you check the code and merge when you are happy?
N-thony
requested changes
Sep 22, 2023
instat/dlgHistogram.vb
Outdated
Comment on lines
297
to
366
| Private Sub UpdateParameter() | ||
| Dim strChangedTextFreq As String = ucrInputAddReorder.GetText() | ||
| clsRaesFunction.RemoveParameterByName("colour") | ||
| clsRaesFunction.RemoveParameterByName("y") | ||
| clsRaesFunction.RemoveParameterByName("fill") | ||
|
|
||
| clsForecatsInfreqValue.AddParameter("f", "as.factor(" & ucrFactorReceiver.GetVariableNames(False) & ")", iPosition:=0) | ||
|
|
||
| If rdoHistogram.Checked Then | ||
| If Not ucrFactorReceiver.IsEmpty Then | ||
| Select Case strChangedTextFreq | ||
| Case strAscending | ||
| clsForecatsReverse.AddParameter("f", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| clsRaesFunction.AddParameter("fill", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strDescending | ||
| clsRaesFunction.AddParameter("fill", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| Case strReverse | ||
| clsForecatsReverse.AddParameter("f", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| clsRaesFunction.AddParameter("fill", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strNone | ||
| clsRaesFunction.AddParameter("fill", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| End Select | ||
| End If | ||
| ElseIf rdoDensity_ridges.Checked Then | ||
| If Not ucrFactorReceiver.IsEmpty Then | ||
| If ucrChkRidges.Checked Then | ||
| Select Case strChangedTextFreq | ||
| Case strAscending | ||
| clsForecatsReverse.AddParameter("f", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| clsRaesFunction.AddParameter("y", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strDescending | ||
| clsRaesFunction.AddParameter("y", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| Case strReverse | ||
| clsForecatsReverse.AddParameter("f", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| clsRaesFunction.AddParameter("y", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strNone | ||
| clsRaesFunction.AddParameter("y", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| End Select | ||
| Else | ||
| Select Case strChangedTextFreq | ||
| Case strAscending | ||
| clsForecatsReverse.AddParameter("f", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| clsRaesFunction.AddParameter("colour", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strDescending | ||
| clsRaesFunction.AddParameter("colour", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| Case strReverse | ||
| clsForecatsReverse.AddParameter("f", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| clsRaesFunction.AddParameter("colour", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strNone | ||
| clsRaesFunction.AddParameter("colour", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| End Select | ||
| End If | ||
| End If | ||
| Else | ||
| If Not ucrFactorReceiver.IsEmpty Then | ||
| Select Case strChangedTextFreq | ||
| Case strAscending | ||
| clsForecatsReverse.AddParameter("f", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| clsRaesFunction.AddParameter("colour", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strDescending | ||
| clsRaesFunction.AddParameter("colour", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=0) | ||
| Case strReverse | ||
| clsForecatsReverse.AddParameter("f", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| clsRaesFunction.AddParameter("colour", clsRFunctionParameter:=clsForecatsReverse, iPosition:=0) | ||
| Case strNone | ||
| clsRaesFunction.AddParameter("colour", ucrFactorReceiver.GetVariableNames(False), iPosition:=0) | ||
| End Select | ||
| End If | ||
| End If | ||
| End Sub |
There was a problem hiding this comment.
I think you don't need to copy paste the same code to the three options as it apply to all of them directly. Just one block will be enough?
There was a problem hiding this comment.
@N-thony , the ucrFactorReceiver passes different parameters on the three buttons i.e histogram , it passes fill, density it passes color and y depending on the Ridges checkbox and underpolygon it passes colour
Is there another way I can do that?
N-thony
requested changes
Sep 22, 2023
N-thony
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8335
@Fidel365 , take a look and test it before @rdstern and @N-thony