Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Titles options in Plots subdialog #8481

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

Vitalis95
Copy link
Contributor

Fixes #8477
@rdstern , @N-thony , @lloyddewit , this is ready for review.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 nicely done. This was perfect. This is the second different edit to the code that I am approving first time round.
@lloyddewit just to report something very nice also about your script windows.
a) I did the check by first sending the script without a title to a script window.
b) Then I made a new empty script window and added a title. It then adds a whole set of titles to the script.
c) Then another script window and took away the title - to see if Vitalis also took it away from the code. He did.

Now "your" script window properties. This is important, because the graphs are a high-spot of R and are very logical, but also produce very long commands. They are obvious bits of code to get the script and tweak. I have been doing that and finding it a bit awkward with the single line being so long. So I tried here and found:

a) It indents progressively. Very nice.
b) Undo and Redo also both work really well. I can easily get back to the long line if I wish - even 5 progressive undos.

My big idea for Antoine is for a sort of primitive undo - but very nice - for R-Instat as a whole. How nice that I am now discovering it is working so sweetly in the script windows!

@lloyddewit lloyddewit changed the title Small improvement in the titles tab for the graphs menu Improved Titles options in Plots subdialog Aug 9, 2023
@lloyddewit lloyddewit merged commit e5545f2 into IDEMSInternational:master Aug 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small improvement in the titles tab for the graphs menu?
3 participants