Ensured position works correctly in Calculator dialog #8470
Conversation
|
@N-thony I am confused on which issue it fixes, given the title? |
There was a problem hiding this comment.
@N-thony I like the change, so I am approving.
a) I still think there could be a bug in the position control, but I would be happy to test that separately later unless you have found something obviously easy to fix?
b) It doesn't seem to work in quite the same way for the data frames. In hindsight, I am actually happy that it is different - so you can choose to overwrite a column, but not a data frame. (If you want to get rid of a data frame then you have to delete it!
c) The other change that affects all dialogs, that I am very keen on, is that when you return to a data frame the focus is always on the first receiver (so not on the receiver that you left it on.) Patrick said that is also just a change in a single line. Can you add that here - or in a second pull request - or should Patrick do it?
Co-authored-by: lloyddewit <[email protected]>
lloyddewit
changed the title
Fixes #8434
@rdstern have a look. Thanks.