Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that the Change of the Data Frame Works correctly in the Pivot Table dialog in Climatic Menu #8437

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

MeSophie
Copy link
Contributor

@MeSophie MeSophie commented Jul 13, 2023

@rdstern, @lloyddewit base on this comment

@MeSophie and @lloyddewit of course I checked something slightly different this time, and found another problem with the new pivot table. I hope it might be easy to fix?

To see the problem:

a) open (say) Domoma from the library, or any of the climatic sets you have been using to check yourself.
b) Then open a second data frame - I used the usual survey.
c) Then go into your climatic pivot table with the wrong data frame.
d) Then try to change to the correct data frame. I found it was impossible. It insists on the original data frame. Even going to the correct data frame and pressing Reset does no good. It insists on sticking with the wrong data frame.

in PR #8431
I corrected the bug when trying to change data frame in Pivot table. Please have a look.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie and maybe @N-thony too. Many thanks - it now seems to work fine. That's a big relief. @lloyddewit I hope we are not too late?

@MeSophie
Copy link
Contributor Author

@MeSophie and maybe @N-thony too. Many thanks - it now seems to work fine. That's a big relief. @lloyddewit I hope we are not too late?

@rdstern most of the work was done by @N-thony

@lloyddewit lloyddewit added the skip-releasenotes PRs that don't affect functionality and should not be included in the release notes label Jul 13, 2023
@lloyddewit lloyddewit merged commit d438024 into IDEMSInternational:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants