Ensured that Script window short cut keys work correctly #8405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated my master
updated my master
updated my branch
rdstern
previously approved these changes
Jun 22, 2023
lloyddewit
requested changes
Jun 22, 2023
There was a problem hiding this comment.
@Patowhiz Thank you, this is a good approach.
Just 2 small suggestions
Co-authored-by: lloyddewit <[email protected]>
Co-authored-by: lloyddewit <[email protected]>
lloyddewit
approved these changes
Jul 10, 2023
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes issue #8301.
@africanmathsinitiative/developers this is ready for review.
@lloyddewit as I understand it, the previous code replaced here, attempted to combine the top visible buttons with the context menu options.
My approach leans towards attempting to treat them differently in implementation. Unlike the top buttons, which are always visible, right click menu options are only visible when the user rights clicks. So I'm now disabling them during opening.
If a user attempts to use short cut keys, then the individual events call functions that give sensible feedback to the users.
This is what was previous there.
Thanks