Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Minor Grid line Frame Strings in sdgThemes and sdgThemesSub #8403

Merged

Conversation

NanyanziAlice
Copy link
Collaborator

@NanyanziAlice NanyanziAlice commented Jun 22, 2023

Fixes (when translation database recreated) #8400

@rdstern, @lloyddewit , @N-thony

In the Themes and ThemesSub subdialogs, changed label from Major Grid Lines to Minor Grid Lines for the right-hand side frames.

@lloyddewit Could you change the following strings in the database?

  1. From Background to Panel
  2. From Panel to Grid Lines

@lloyddewit
Copy link
Contributor

Could you change the following strings in the database?

@NanyanziAlice Thank you for making these changes. The next time I recreate the database, the text changes you made should be visible (and automatically translated into the different languages). I added a note to issue #8400.

@rdstern There's nothing to test yet, but if you agree with the changes in issue #8400, then please approve this PR. I will then merge.
Thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing as I have been told!

@lloyddewit lloyddewit added the skip-releasenotes PRs that don't affect functionality and should not be included in the release notes label Jun 22, 2023
@lloyddewit lloyddewit merged commit 673af06 into IDEMSInternational:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants