Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that menu translations in Portuguese are correctly capitalized #8390

Conversation

lloyddewit
Copy link
Contributor

Fixes #8340
Thank you to @rachelkg for making the changes in CrowdIn.
@rdstern please could you test? thanks

@lloyddewit lloyddewit added the bug label Jun 19, 2023
@rdstern
Copy link
Collaborator

rdstern commented Jun 19, 2023

@lloyddewit and @rachelkg this seems improved, but

image

The Experiments is now capitalised, but not climatic.

And I may have found more, though perhaps not for now?

Here is part of the above, now in English:

image

Notice each main word in English is capitalised, but not in the Portuguese? I think perhaps in no other language than English? Should we:

a) Leave these as they are - at least for now?
b) Capitalise the words in all languages - perhaps individually or through code?
c) Uncapitalise - is that a word - the English?

Roger

@lloyddewit
Copy link
Contributor Author

The Experiments is now capitalised, but not climatic.

I will fix this.

Notice each main word in English is capitalised, but not in the Portuguese? I think perhaps in no other language than English?

Good spot. It will be a lot of work to change this. Also, inconsistencies are likely to creep back in for each new release because the new machine translation will not follow our rules. Finally, different languages may have different norms regarding capitalization so standardization may not be appropriate. Is this a high priority? I suggest that we leave as is.

@lloyddewit
Copy link
Contributor Author

@rdstern please could you test again? thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

But I assume you want me to be "picky".
a) Edit > Copy
b) Climatic > date
c) Prepare > Factor > Contrasts

They are the only 3 I could still find that start in lower case.

@lloyddewit
Copy link
Contributor Author

@rdstern Picky is just what I need, sorry I missed those.
Please could you test again? thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lloyddewit looks fine.
I noticed quite a number of language changes in Portuguese that I assume come from you. There have also been a lot of Spanish changes and I wonder if they were made by Carla? They still all appear to come from Danny. Could that be altered easily to come from the person who made the change?

@lloyddewit
Copy link
Contributor Author

@rdstern Correct, Portuguese changes are from me, Spanish changes are from Carla.
The PR always comes from Danny because he owns the automatic process that raises/updates the PR whenever something changes in CrowdIn (but there is no personal involvement from him).

@lloyddewit lloyddewit merged commit 547e716 into IDEMSInternational:master Jun 20, 2023
@lloyddewit lloyddewit deleted the issue8340PortugueseCapitalization branch June 20, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lower case in Portuguese translation
2 participants