-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved default output startup commands, comments, heights of outputs and R-Instat initialization #8331
Improved default output startup commands, comments, heights of outputs and R-Instat initialization #8331
Conversation
updated my master
updated my master
Updated my master
updated my master
updated my master
update my master
updated my master
updated my master
updated my master
updated my master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Patowhiz this has done a lot. I found only one small detail to change, and would like to see it merged as soon as checked by @lloyddewit
The one very minor suggestion is that, at the start it says:
# Setting display options (e.g Number of significant digits)
That's fine, but it also repeats that, whenever you use the dialogue.
I went in to change the language and it said that again!
The Options Dialog doesn't have the Comments control - perhaps it should? But as a quick change could the Comment for this dialog be simply #Setting Options? (Without changing it on startup, from what it is now.
I did try the output window and it seems much better. I'd like to keep trying it, once it is merged.
That's so minor that I am approving.
@rdstern thanks for testing this even though I'm still making major changes on the different bits. |
@Patowhiz I quite liked the current, more detailed, message on Startup, with the brief message - possibly with access to the Comment control, thereafdter? But, if that takes too much time, I could live with the brief message throughout. And - assuming @lloyddewit is happy with the code, then I'd be happy to see these changes merged as soon as you are ready, and then another pull request for the further work. |
@Patowhiz Is this PR ready for peer review or do you still wish to make some changes? thanks |
@lloyddewit you can go ahead and review this while I keep making more additions |
@Patowhiz I think it will be more efficient if I review when the PR is complete, thanks |
@Patowhiz and @lloyddewit I would like to merge what has been done into the next release. It changes the comments and startup, and therefore is captured in screeen shots for our documents and videos. So good to have these changes soon. |
@lloyddewit @rdstern
@rdstern as discussed before, there is much more that I'm adding in regards to the outputs;
Considering the urgency of testing this. I can do the above in a separate PR. |
@rdstern if you're willing to approve, then I can peer review and we can hopefully merge into the release this week. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving. However, previously it changed the default Comment text into Dialog:
Iy has now returned to the previous setting:
I think that's just me, because I have also been using previous versions. @lloyddewit Could you just check this point as you review.
@rdstern all previous settings should be retained. Only new users should have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Patowhiz Thank you for this.
When I reviewed, I noticed lines that were commented out rather than deleted. Is this work in progress?
Also, some of the changes to RLink (also frmMain?) looked like refactoring changes rather than changes directly linked to this PR. Is that correct?
Happy to approve and merge.
Fixes #8091
Fixes #7854
Fixes partly #7979
@africanmathsinitiative/developers this PR has major changes on
frmMain
. I suggested any other changes to be done onfrmMain
to wait until this PR is merged. This will help in preventing conflicts.