Added drop variables feature to Stack(Pivot Longer) dialog #8318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating master
updating master
updating master
rdstern
requested changes
May 9, 2023
There was a problem hiding this comment.
@Vitalis95 great - it works fine. Just 3 small suggestions:
a) The Control on the right says Drop Value(s). Change that to Drop Variable(s).
b) You don't need the extra checkbox and control on the bottom left. Instead add the checkbox to the Drop Variable(s) on the right, which is then aleays visible.
c) Check, but I don't think the Drop Prefix works for the dialogue with multiple sets. If I am right, then when there are multiple sets, this should be invisible?
|
@rdstern have a look at it |
lloyddewit
reviewed
May 10, 2023
lloyddewit
approved these changes
May 10, 2023
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6868
@rdstern @lloyddewit @N-thony , added
Drop Variablescontrol which drops the variables before reshaping.