Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that list of last 10 opened dialogs is displayed in correct language #8295

Merged

Conversation

lloyddewit
Copy link
Contributor

@lloyddewit lloyddewit commented Apr 28, 2023

Fixes #8280.
The main tool bar has a drop down list of the 10 most recent dialogs opened. This PR ensures that this list is always displayed in the current language (English, French etc.).

@lloyddewit lloyddewit added the bug label Apr 28, 2023
@lloyddewit lloyddewit self-assigned this Apr 28, 2023
@lloyddewit lloyddewit marked this pull request as draft April 28, 2023 11:00
@lloyddewit
Copy link
Contributor Author

Ongoing, not yet ready for testing

@lloyddewit lloyddewit marked this pull request as ready for review April 30, 2023 10:24
@lloyddewit
Copy link
Contributor Author

lloyddewit commented Apr 30, 2023

@rdstern This PR is now ready for testing.

One small idiosyncracy is that if the language is non-English (e.g. Russian) and the user toggles the menu bar to English, then the list of dialogs is translated from Russian to English (as expected). If the user then opens a new dialog, then the dialog is in Russian (as expected). When the user closes the Russian dialog, then the list of dialogs is shown in Russian (which may look odd to the user when the rest of the menu bar is still toggled to English).
I personally think this is OK, because the user has just been using the dialog with the Russian title. If needed, the user can still toggle the language again using the button on the menu bar. The list of dialogs is always in a consistent language (i.e. all list items shown in Russian, or all list items shown in English).

I didn't resolve this idiosyncracy because it adds complexity to the code (I have to change the way the menu language toggle works) and I wasn't sure it was worth it.
But if you'd like the idiosyncracy resolved, then I'm happy to do it.

thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lloyddewit this all looks great.

If you are ever bored, then I notice that tooltips have yet to be translated - unless this mat be in the new database?

@lloyddewit lloyddewit merged commit 2b024db into IDEMSInternational:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message on PICSA graphs when R-Instat in language other than English
2 participants