Design changes in Bar chart #8294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
previously approved these changes
Apr 30, 2023
There was a problem hiding this comment.
@derekagorhom this looks fine and I also like your summary of which part of the issue it is fixing. I also looked in Russian and the layout looks fine there.
I hope @COLIEWO will soon be involved, but would be happy for this to be merged as a start. And I have, of course, now found an item d) to add to the list!
lloyddewit
requested changes
May 1, 2023
|
@derekagorhom sorry for the delayed response, the positioning of the labels looks okay. |
Co-authored-by: lloyddewit <[email protected]>
lloyddewit
approved these changes
May 1, 2023
lloyddewit
added
the
skip-releasenotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partly #8288
This Fixes the Item c on the list.
Item b is being fixed in PR #8293 by @lloyddewit
Item a will be fixed after PR #8293 is merged
This PR is ready for review
@COLIEWO can you test this.
Thanks