-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Rhelp for Model Menu Dialogs #8181
Improved Rhelp for Model Menu Dialogs #8181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekagorhom well done. This works really nicely now.
@lloyddewit I hope the code is ok, and if so it could be merged soon?
@ChrisMarsh82 if it is merged, and you are doing another build, then it would be good to include this. It fixes a couple of small errors in the Model Keyboard dialogue. But it isn't worth making a special effort for this. I'd be delighted if anyone used this dialogue sufficiently to find these problems. Maybe worth a small prize. So no harm if it waits for the March release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekagorhom Thanks for the PR, looks good, just a few comments
Co-authored-by: lloyddewit <[email protected]>
Co-authored-by: lloyddewit <[email protected]>
@lloyddewit i have made all the changes except the one related the |
@derekagorhom thanks, just open comment above. |
@derekagorhom thank you, looks good, happy to approve. @rdstern there are some small changes since your last approval. If you can test/approve, then we can merge, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
fixes #8160
replaces #8165
I have updated this branch with the changes done on PR #8159 added the
Rhelp dropdown
to the UseModel keyboard
,Hypothesis Tests
,Fit Mode
l andPrepare > Column: Numeric > Enter dialogue.
@N-thony , @rdstern this PR is ready for review.