Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Layout changes in New Data Frame dialogue #8058

Merged

Conversation

derekagorhom
Copy link
Contributor

This fixes the problem with variable name and variable label not being translated correctly in the New Data Frame dialogue.

@N-thony can review this

@derekagorhom
Copy link
Contributor Author

@lloyddewit , @N-thony i checked the new version and this still has not been resolved

image

and also this
image

@N-thony
Copy link
Collaborator

N-thony commented Jan 30, 2023

@lloyddewit , @N-thony i checked the new version and this still has not been resolved

image

and also this image

@derekagorhom I also noticed here the two input drop down controls don't have the default value/text. And it seems to be affected by the translation. We should set the two controls to DoNotTranslate in the database.

@derekagorhom
Copy link
Contributor Author

@lloyddewit can you remove the last two commits i did

@lloyddewit
Copy link
Contributor

@lloyddewit can you remove the last two commits i did

In Git, You can't remove a commit, but you can make a new commit with an older version of the file.
I wrote some instructions in the wiki that explains how to do this.
Please try this (with local support if needed) and let me know how you get on.
Thanks

@derekagorhom
Copy link
Contributor Author

@N-thony i will make the DB translation once this is merged if that is ok with you

@N-thony
Copy link
Collaborator

N-thony commented Jan 30, 2023

@lloyddewit , @N-thony i checked the new version and this still has not been resolved
image
and also this image

@derekagorhom I also noticed here the two input drop down controls don't have the default value/text. And it seems to be affected by the translation. We should set the two controls to DoNotTranslate in the database.

@derekagorhom also check the code, it is probably the issue with code too.

@derekagorhom
Copy link
Contributor Author

@N-thony i made the fix to the drop down controls on the list options for the New dataframe dialogue.
can you have a look.

instat/dlgNewDataFrame.vb Outdated Show resolved Hide resolved
@derekagorhom
Copy link
Contributor Author

@N-thony i have made the changes requested, can you have a look again

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@lloyddewit lloyddewit added the skip-releasenotes PRs that don't affect functionality and should not be included in the release notes label Mar 27, 2023
@lloyddewit lloyddewit merged commit 495285d into IDEMSInternational:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants