-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation Layout changes in New Data Frame dialogue #8058
Translation Layout changes in New Data Frame dialogue #8058
Conversation
@lloyddewit , @N-thony i checked the new version and this still has not been resolved |
@derekagorhom I also noticed here the two input drop down controls don't have the default value/text. And it seems to be affected by the translation. We should set the two controls to |
@lloyddewit can you remove the last two commits i did |
In Git, You can't remove a commit, but you can make a new commit with an older version of the file. |
@N-thony i will make the DB translation once this is merged if that is ok with you |
@derekagorhom also check the code, it is probably the issue with code too. |
@N-thony i made the fix to the drop down controls on the list options for the New dataframe dialogue. |
@N-thony i have made the changes requested, can you have a look again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now.
This fixes the problem with
variable name
andvariable label
not being translated correctly in the New Data Frame dialogue.@N-thony can review this