Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to show loading screen that keeps responsive from anywhere #8011

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChrisMarsh82
Copy link
Contributor

This is not used anywhere at the moment but the plan is to take code out of R-script that currently shows this screen.
I have added a timeout on the screen as the code relies on hideLoadingScreen being called.

instat/frmSetupLoading.vb Show resolved Hide resolved
instat/frmSetupLoading.vb Outdated Show resolved Hide resolved
instat/frmSetupLoading.vb Outdated Show resolved Hide resolved
instat/frmSetupLoading.vb Outdated Show resolved Hide resolved
instat/frmSetupLoading.vb Show resolved Hide resolved
instat/frmSetupLoading.vb Show resolved Hide resolved
@lloyddewit
Copy link
Contributor

@ChrisMarsh82
I wasn't sure if I should review this or not.
I'd prefer to merge this PR when all the code is called and there is some testable functionality. Otherwise I'm reviewing without understanding the context, and we risk having overlooked 'orphan' code in the code base.
I hope that's OK, happy to dicsuss if needed.

@ChrisMarsh82
Copy link
Contributor Author

@lloyddewit I'm happy for this to wait till I have a use case.

@rdstern
Copy link
Collaborator

rdstern commented Jun 15, 2024

@ChrisMarsh82 are you happy for this pull request to keep sitting here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants