-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added counts with percentages option to summary function in Describe > Specific Tables/Graphs > Summary Tables dialog #7784
Added counts with percentages option to summary function in Describe > Specific Tables/Graphs > Summary Tables dialog #7784
Conversation
@rdstern if you can test/approve, then we can merge |
@N-thony who do you suggest should peer review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lloyddewit even though I'm not strong in R but I did a quick look of this with Lily and I'm convinced everything is okay. Over to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lloyddewit I am happy to approve if the code is ok, but I can't check, until the dialogue is changed to allow more than one of these summaries to be included. @lilyclements I wonder who will do this - perhaps choose someone at the workshop this week?
@lilyclements what's the reason you closed this? do you plan to implement in a new PR? thanks |
@lloyddewit Ah was an accident when deleting old branches! Thanks for pointing this one out! |
@africanmathsinitiative/developers @rdstern this is ready to review.
This PR adds a parameter to include counts with percentages in summary function called
include_counts_with_percentage
as discussed in #7621.This is default
FALSE
, but whenTRUE
, includes the counts when percentages are chosen.E.g.
gives:
Whereas
gives: