-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fixed in the Merge Dialogue #7415
Minor bug fixed in the Merge Dialogue #7415
Conversation
@N-thony Thank you for this PR. |
@N-thony I assume this is the main prepare > reshape > merge dialogue, but I'm not sure what to do to check this is resolved? What data and example gace that error before? |
@rdstern while testing PR #7404 with the survey dataset, tried to open the Merge dialogue, you will get the bug that this PR attends to fix. To quickly avoid that bug in the merge version since it was easy to fix, I did the fix in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem with Merge here, which there was with the pull request @N-thony pointed me to. I hope all will still work when both are merged.
Ok from my side now. Over to @lloyddewit or @ChrisMarsh82
I don't see any functional changes in the code, so I can't see how this PR has fixed a bug. |
The functional change in this PR is that 'New' has been added to lines 22, 23, and 29. |
Fixes #7414
@africanmathsinitiative/developers this is ready for review.