Improved the Describe > One Variable > Summarise dialog #7410
Conversation
Updating master
updating master
Updating Master
|
@HawardKetoyoMsatsi Please could you review? |
There was a problem hiding this comment.
@Ivanluv and @lilyclements this is excellent now. All over except the shouting! I used the usual survey data and could get all I wanted in terms of the summary statistics.
Just some cosmetic things remain. I think:
a) Is the terminology the wrong way round? The default is Display summaries as rows. I think you mean columns? When I make both summaries and variables as rows, then I only get one row and many columns. So maybe all you need to change is the label.
b) When I untick both, there is just a single column. And there is no labelling, just the numbers.
c) There is the margin All, over which I have no control. In my examples it just gives the total count. I'm not sure what that means and am not sure I want the margin here?
|
@rdstern could you have a look again? |
|
@HawardKetoyoMsatsi Thank you for your review. I went through the comments/responses and set the comments to resolved. If I misunderstood anything, then let me know. |
lloyddewit
dismissed
HawardKetoyoMsatsi’s stale review
I consider all comments resolved
lloyddewit
changed the title
|
@lloyddewit this fully fixes #7081 |
fixes #7081 and replaces PR #7123
@africanmathsinitiative/developers this is ready for review