Fixed bug related to data frame length in Prepare > Numeric > Regular Sequence dialog #7369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated my master
updating my master
lloyddewit
approved these changes
Apr 11, 2022
|
@rdstern Please could you test? thanks |
rdstern
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
It is now better in that it changed the 34 to 36. But I still managed to get:
Now what did I do. I pressed reset on survey and it went back to survey1. Then I went back to survey and made the 34 into 6. And I think that was it - hey presto!. I can't show the R code because it has crashed out. Perhaps I'll try again!
Aha, before that, maybe it is ok, because here is the problem:
And that's a different problem that has now been fixed. So I'll approve now and hope it will all then "be alright on the night"
|
@rdstern yes I'm aware of that bug too. @N-thony and @ChrisMarsh82 are working on it. |
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7359.
@africanmathsinitiative/developers this is ready for review.