-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming sub-menu items in Describe, Prepare, Climatic and Option by Context menus and Right Clicks. #7308
Renaming sub-menu items in Describe, Prepare, Climatic and Option by Context menus and Right Clicks. #7308
Conversation
updating master
updating master
Updating Master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great as far as it goes.
In my suggestions, items a) and b) are done.
Item c) remains. That's partly to clarify the Select and Filter items, and also to add the item @N-thony is working on - to Add (Merge) Data.
Please can @shadrackkibet check and merge. Can he also comment on my suggestions for clafying the Filter and Select entries. If agreed, then perhaps do them before merging, or make them a separate pull request.
@rdstern @shadrackkibet |
@rdstern @shadrackkibet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still says Filter... rather than Filter Rows...
And the Describe T> wo Variables should become Describe Two/Three Variables
@rdstern I have made changes in the database, they are now visible. |
@Vitalis95 could you send screenshots of the translation DB changes. Looks like GitHub cannot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Perfect - for me anyway.
@shadrackkibet please also check and then good to merge
@shadrackkibet here are the screenshots |
@Vitalis95 why the changes on |
Then you forgot the right click in column metadata! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdstern if you approve then we can merge. Thanks
@Vitalis95 could you make this title a bit "specific"? which menu items changed? what else? Remember this title is used in the release notes therefore it should be informative to the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadrackkibet I wonder about adding 2-Way Frequencies and 3-Way Frequencies first - see #7259 ., but also approve if you want to do that separately.
@Vitalis95 consider adding this on a separate PR. |
Fixex #7297
@rdstern @shadrackkibet ,this PR is ready for review.
@N-thony will make the database changes so that it will be visible on the runtime