Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming sub-menu items in Describe, Prepare, Climatic and Option by Context menus and Right Clicks. #7308

Merged
merged 14 commits into from
Mar 22, 2022

Conversation

Vitalis95
Copy link
Contributor

Fixex #7297
@rdstern @shadrackkibet ,this PR is ready for review.
@N-thony will make the database changes so that it will be visible on the runtime

rdstern
rdstern previously approved these changes Mar 16, 2022
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great as far as it goes.
In my suggestions, items a) and b) are done.
Item c) remains. That's partly to clarify the Select and Filter items, and also to add the item @N-thony is working on - to Add (Merge) Data.
Please can @shadrackkibet check and merge. Can he also comment on my suggestions for clafying the Filter and Select entries. If agreed, then perhaps do them before merging, or make them a separate pull request.

@Vitalis95
Copy link
Contributor Author

@rdstern @shadrackkibet
I have changed the label to Duplicate Rows... in Climatic and Options by Context menus
Also Changed Filter to Filter Rows... and Column selection to Select Columns.. in all right clicks
@N-thony will update them in the database to be visible on the runtime

@Vitalis95
Copy link
Contributor Author

@rdstern @shadrackkibet
Have a look at it

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still says Filter... rather than Filter Rows...
And the Describe T> wo Variables should become Describe Two/Three Variables

@Vitalis95
Copy link
Contributor Author

@rdstern I have made changes in the database, they are now visible.

@shadrackkibet
Copy link
Collaborator

@Vitalis95 could you send screenshots of the translation DB changes. Looks like GitHub cannot diff a binary file.

rdstern
rdstern previously approved these changes Mar 16, 2022
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Perfect - for me anyway.
@shadrackkibet please also check and then good to merge

@Vitalis95
Copy link
Contributor Author

Vitalis95 commented Mar 16, 2022

@shadrackkibet here are the screenshots
image
image
image
image
image

@shadrackkibet
Copy link
Collaborator

@Vitalis95 why the changes on instat/translations/rInstatTranslations.db-journal? I can't seem to understand this.

@shadrackkibet
Copy link
Collaborator

shadrackkibet commented Mar 16, 2022

Then you forgot the right click in column metadata!

Copy link
Collaborator

@shadrackkibet shadrackkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdstern if you approve then we can merge. Thanks

@shadrackkibet
Copy link
Collaborator

@Vitalis95 could you make this title a bit "specific"? which menu items changed? what else? Remember this title is used in the release notes therefore it should be informative to the user.
image

@Vitalis95 Vitalis95 changed the title Changing menu items Renaming sub-menu items in Describe, Prepare, Climatic and Option by Context menus and Right Clicks. Mar 17, 2022
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadrackkibet I wonder about adding 2-Way Frequencies and 3-Way Frequencies first - see #7259 ., but also approve if you want to do that separately.

@shadrackkibet
Copy link
Collaborator

@shadrackkibet I wonder about adding 2-Way Frequencies and 3-Way Frequencies first - see #7259 ., but also approve if you want to do that separately.

@Vitalis95 consider adding this on a separate PR.

@shadrackkibet shadrackkibet merged commit f8da0f3 into IDEMSInternational:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants