fixes sizing of geom list with aes #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
@dannyparsons that's a relief. It seems ok now.
Good if @lloyddewit or @shadrackkibet could also check, so this can be merged
shadrackkibet
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7296
@rdstern Can you check the sizing and visibility is fixed? It looks ok on my machine now.
I had to make the nud control wider, but I think it looks ok still. See what you think.
The sizing is not quite perfect but I think it's not very noticeable and all controls are non-overlapping and visible.