-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the data view info when selection is applied #7278
Updated the data view info when selection is applied #7278
Conversation
I am approving, because it now works. But I wonder whether we should try to do better? Here it is with a select and a filter This is default and they are incredibly small. I am not good on design, but suggest that @N-thony and @shadrackkibet what is your view? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but also see comment with a suggestion.
@rdstern I made the above change, please test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdstern if you approve then we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadrackkibet I am approving, though I quite like @Patowhiz suggestion. If merged as it stands, then perhaps this can be considered later? As you wish.
@N-thony could you open an issue for this? then you can consider it on a separate PR. @rdstern another option is to put the label at the top where variable's names are. |
Fixes #7277
I have added the info concerning the column selection when it is applied to DataView, I also adjusted the size of the info when the application is minimized or maximized.
@africanmathsinitiative/developers @rdstern this is ready for review. Thanks.