Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug on the factor levels control being hidden in some dialogs #7271

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Mar 4, 2022

Fixes #7269
@rdstern I had a quick discussion on this with @ChrisMarsh82 and then found that the problem was more general mainly under the following dialogues and ucrInputFacotrLevels itself:

  • dlgCalculateTreatementDifferences
  • dlgClimaticDataEntry
  • dlgCalculateTreatementLines
  • dlgSetupForDataEntry
  • ucrInputFacotrLevels
    To fix this, we just set the AutoSize property to False and also adjusted the Size of ucrInputFacotrLevels and it corresponds to the above dialogues.

Please take a look. Thanks.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-thony great. I have checked where I found the problem, and that is fixed. I also looked at the setup for data entry and that also seems fine, but I didn't see it before.
I have not checked others, because you just give the function names, so I'm not quite sure which dialogues, nor what I should look for. But I assume the problem is solved, and am very relieved. Over to @lloyddewit or @shadrackkibet for second approval and merge.
That's a relief!

@shadrackkibet shadrackkibet changed the title Fixed bug on the ucrInputFactorLevels being hidden on some controls dialogue Fixed bug on the factor levels control being hidden in some dialogs Mar 5, 2022
Copy link
Collaborator

@shadrackkibet shadrackkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@africanmathsinitiative/developers I think we might have this kind of problem in other places. Can we get volunteers to quickly check and report on dialogs with this kind of problem? Let us get volunteers by menu.

Shadrack - Climatic Menu

@shadrackkibet shadrackkibet merged commit a40534b into IDEMSInternational:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disturbing bug in climate data entry in Version 0.7.4
3 participants