-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide drop empty rows checkbox when no file is selected in import dataset dialog #7253
Hide drop empty rows checkbox when no file is selected in import dataset dialog #7253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice example of a simple task where I would like the programmer, here @mmulahvictor to do more testing and also to read the task carefully, before sending it for review.
a) When I press Reset as suggested by @shadrackkibet it is perfect and all works fine. But when I return to the dialogue again, the option has returned. So it isn't obeying the rule that the dialogue re-opens as it was left.
b) Shadrack suggested the message on not displaying files of this type could/should(?) also be changed. It isn't yet. Either there should be a comment that this remains to be done, or that the programmer doesn't agree, and so decided not to do it.
@N-thony made the changes for the message on not displaying files of this type in the database. |
@mmulahvictor when PR #7243 is merged, please could you pull the changes into this PR so that the new text can also be tested, thanks |
Updating importdataset branch
@shadrackkibet can you look at the changes I have made above? |
@Ivanluv could you review the following PR? |
@rdstern please could you test? thanks |
Fixes #7173
@africanmathsinitiative/developers
This is ready for review