Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide drop empty rows checkbox when no file is selected in import dataset dialog #7253

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

mmulahvictor
Copy link
Contributor

Fixes #7173

  • I have hidden the drop checkbox when no file is selected.
  • I have disable ok which appeared after reseting the dialog.

@africanmathsinitiative/developers
This is ready for review

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice example of a simple task where I would like the programmer, here @mmulahvictor to do more testing and also to read the task carefully, before sending it for review.
a) When I press Reset as suggested by @shadrackkibet it is perfect and all works fine. But when I return to the dialogue again, the option has returned. So it isn't obeying the rule that the dialogue re-opens as it was left.
b) Shadrack suggested the message on not displaying files of this type could/should(?) also be changed. It isn't yet. Either there should be a comment that this remains to be done, or that the programmer doesn't agree, and so decided not to do it.

@mmulahvictor
Copy link
Contributor Author

@N-thony made the changes for the message on not displaying files of this type in the database.

@lloyddewit
Copy link
Contributor

@mmulahvictor when PR #7243 is merged, please could you pull the changes into this PR so that the new text can also be tested, thanks

@mmulahvictor
Copy link
Contributor Author

@shadrackkibet can you look at the changes I have made above?

@shadrackkibet
Copy link
Collaborator

@Ivanluv could you review the following PR?

@lloyddewit
Copy link
Contributor

@rdstern please could you test? thanks

@shadrackkibet shadrackkibet changed the title Hide drop empty rows checkbox when no file is selected Hide drop empty rows checkbox when no file is selected in import dataset dialog Mar 16, 2022
@shadrackkibet shadrackkibet merged commit cbcadf2 into IDEMSInternational:master Mar 16, 2022
@mmulahvictor mmulahvictor deleted the importdataset branch March 16, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Drop empty Rows and All files of this type checkboxes
5 participants